Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@test/check_vault_bucket_name.py`:
- Line 42: The default key name used when reading the env var into key_name is
inconsistent with StorageConfig; change the default from "portfolio_bucket_name"
to "object_storage_bucket_name" so tests align with StorageConfig
expectations—update the assignment that sets key_name (the os.getenv call) to
use "object_storage_bucket_name" as the fallback and ensure any related
assertions referencing StorageConfig.object_storage_bucket_name remain
consistent.

In `@wacruit/src/apps/portfolio/file/aws/config.py`:
- Around line 20-32: The __init__ in the AWS config currently assumes
OCISecretManager.get_secret always returns the requested keys and will raise
KeyError if a secret is missing; update the __init__ to handle missing secrets
by wrapping each call to OCISecretManager.get_secret (for bucket_name, region,
endpoint_url, access_key_id, secret_access_key) with a try/except KeyError (or
using a .get-like fallback) and fall back to sensible defaults such as
environment variables or None; keep the is_available() check but ensure
missing-key handling prevents startup crashes when a particular secret is
absent.

In `@wacruit/src/apps/portfolio/file/aws/s3/client.py`:
- Line 7: S3Client가 모듈 레벨의 전역 storage_config를 고정으로 캡처해 환경 전환 시 이전 엔드포인트/자격증명을 계속
사용하게 되는 문제이므로, S3Client 생성 시 또는 호출 시 최신 설정을 주입하도록 변경하세요; 구체적으로 현재의
storage_config 전역 참조를 제거하고 S3Client.__init__에 storage_config 파라미터(또는 설정을 반환하는
콜백)를 추가하거나, S3Client.get_client()/connect() 같은 메서드 내부에서 런타임에 storage_config를 다시
조회하도록 수정하여 동적 환경 전환을 지원하게 만드세요.

In `@wacruit/src/tests/portfolio/file/test_portfolio_file_service.py`:
- Around line 25-29: The expected_url in the test currently builds the custom
endpoint without a trailing slash causing mismatch with boto3's
generate_presigned_post; update the expression that constructs expected_url (the
conditional using storage_config.endpoint_url and storage_config.bucket_name) to
append a trailing '/' after the bucket for the custom endpoint branch so it
matches the AWS default branch and the URL returned by generate_presigned_post.
- Around line 152-156: The tests fail because StorageConfig (env_prefix =
"OBJECT_STORAGE_") expects OBJECT_STORAGE_BUCKET_NAME but .env.test defines
S3_PORTFOLIO_BUCKET_NAME, so storage_config.bucket_name becomes empty; fix by
either updating .env.test to set
OBJECT_STORAGE_BUCKET_NAME=wacruit-portfolio-test or by setting
storage_config.bucket_name="wacruit-portfolio-test" in the test setup (e.g., in
conftest.py where the bucket is created) so the Key in
test_portfolio_file_service.py uses the actual bucket name.

In `@wacruit/src/tests/portfolio/oracle/test_oracle_object_storage_crud.py`:
- Around line 50-55: The test helper _build_storage_context creates a new
StorageConfig() and separately instantiates S3Client().client which reads the
module-global storage_config in
wacruit/src/apps/portfolio/file/aws/s3/client.py, and it also mutates
settings.env without restoring it; fix this by creating a single StorageConfig
instance and ensuring the S3 client uses that same instance (e.g., set the
client module's storage_config to the created StorageConfig or construct the
S3Client with that config) and after _reset_singletons() and client creation
restore settings.env to its original value so tests do not leak global env;
update references in _build_storage_context, StorageConfig, and S3Client usage
accordingly.

In `@wacruit/src/tests/portfolio/oracle/test_oracle_secret_integration.py`:
- Around line 26-28: The singleton reset function _reset_singletons currently
mutates SingletonMeta._instances without synchronization; modify it to acquire
SingletonMeta._lock while removing entries for OCISecretManager and S3Client to
avoid race conditions. Specifically, inside _reset_singletons obtain
SingletonMeta._lock (e.g., with a context or explicit acquire/release) and then
pop those keys from SingletonMeta._instances, preserving thread safety while
resetting singletons.

In `@wacruit/src/tests/project/test_project_service.py`:
- Around line 112-127: The test currently false-positives because it never
creates the S3 object before calling delete_project_image; ensure the object
exists first, e.g. use the generated presigned URL to PUT the file or call the
S3 client put_object (project_service._s3_client.client.put_object) to upload
"PROJECT/{project.id}/image.png" after
generate_presigned_url_for_post_image/register_project_image_info_in_db, then
call project_service.delete_project_image(upload_response.project_image_id) and
finally assert head_object raises ClientError; reference
generate_presigned_url_for_post_image, register_project_image_info_in_db,
delete_project_image and project_service._s3_client.client.head_object to locate
where to add the pre-delete upload.

---

Nitpick comments:
In `@test/check_vault_bucket_name.py`:
- Around line 16-20: The helper function _required_env is defined but never used
in this script; either delete the _required_env function to remove dead code or
replace existing getenv usage with calls to _required_env (e.g., where env
variables are read) so the helper is actually utilized; locate the _required_env
definition and remove it or refactor the env retrieval sites to call
_required_env accordingly.

In `@wacruit/src/tests/portfolio/oracle/test_oracle_presigned_contract.py`:
- Around line 46-68: The helper functions _assert_post_contract and
_assert_get_contract recreate the storage context by calling
_build_storage_context() unnecessarily; change their signatures to accept an
s3_client parameter (instead of calling _build_storage_context inside), remove
the internal _build_storage_context() call, and use the passed s3_client when
calling generate_presigned_post_url / generate_presigned_get_url; update all
test callers to pass the existing s3_client returned by the test setup so no
duplicate clients are created.
- Around line 25-27: The three helper routines _reset_singletons, _target_env,
and _build_storage_context are duplicated across tests; extract them into a
shared test utility module (e.g., tests/util/test_helpers or similar), export
those functions, and replace the duplicated definitions in both
test_oracle_presigned_contract.py and test_oracle_secret_integration.py with
imports from that module; ensure you reference and update usages of
SingletonMeta._instances manipulation in _reset_singletons, the
environment-handling logic in _target_env, and the storage construction in
_build_storage_context so existing tests import the helpers and run unchanged.

In `@wacruit/src/tests/portfolio/oracle/test_oracle_secret_integration.py`:
- Around line 56-81: test_storage_configuration_is_available mutates
settings.env and doesn't restore it, which can leak state into other tests;
update the test to restore settings.env and call _reset_singletons() after
changing it (either by using a pytest fixture like restore_settings_env that
saves and yields the original settings.env or by wrapping the modification in a
try/finally block inside test_storage_configuration_is_available), ensuring the
original value is reassigned to settings.env in the cleanup path so subsequent
tests see the original environment.